search

convexengineering / gpfit

Fit posynomials to data
http://gpfit.readthedocs.io/en/latest/
MIT License
10 stars 7 forks source link

Create Unit Test for fit.py #80

Closed nanjekyejoannah closed 3 years ago

nanjekyejoannah commented 6 years ago

Fixes #4

This PR adds unit tests for fit.py.

acdl-jenkins commented 6 years ago

Can one of the admins verify this patch?

acdl-jenkins commented 6 years ago

Can one of the admins verify this patch?

bqpd commented 6 years ago

add to whitelist

bqpd commented 6 years ago

test this please

bqpd commented 6 years ago

this looks great, thanks @jnanjekye ! (and sorry for the late response). These tests should be added to run_tests.py so that they are run along with the other tests

nanjekyejoannah commented 6 years ago

@bqpd I have made necessary changes, take a look.

bqpd commented 6 years ago

test this please

nanjekyejoannah commented 6 years ago

@bqpd I will revert with changes to address the test outcomes.

bqpd commented 6 years ago

Awesome, thanks!

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

bqpd commented 6 years ago

@acdljenkins could you check on Marshall? I think he's stuck in a for loop

On Jan 25, 2018 18:31, "Marshall Galbraith" notifications@github.com wrote:

test this please

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/convexengineering/gpfit/pull/80#issuecomment-360635770, or mute the thread https://github.com/notifications/unsubscribe-auth/ABagGMyLhwVGdzqDIWIsoo9mb_ZGlOIkks5tOQ6ogaJpZM4Q8lO0 .

bqpd commented 6 years ago

(@galbramc, anything I can help with?)

On Jan 25, 2018 20:58, "Edward Burnell" eburn@mit.edu wrote:

@acdljenkins could you check on Marshall? I think he's stuck in a for loop

On Jan 25, 2018 18:31, "Marshall Galbraith" notifications@github.com wrote:

test this please

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/convexengineering/gpfit/pull/80#issuecomment-360635770, or mute the thread https://github.com/notifications/unsubscribe-auth/ABagGMyLhwVGdzqDIWIsoo9mb_ZGlOIkks5tOQ6ogaJpZM4Q8lO0 .

galbramc commented 6 years ago

gpfit_PullRequest_PyLint is running, and I don't know why. I can't see anything wrong in the settings, and gpfit_PullRequest_Unit is working just fine...

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test this please

pgkirsch commented 3 years ago

@nanjekyejoannah thank you for creating this PR and I'm so sorry it sat unmerged for so long. I made some minor tweaks and have now merged it. Thanks again for the contribution!