search

convexengineering / gpfit

Fit posynomials to data
http://gpfit.readthedocs.io/en/latest/
MIT License
10 stars 7 forks source link

Python3 compatibility. #85

Closed 1ozturkbe closed 3 years ago

1ozturkbe commented 5 years ago

Had a few minutes, figured it could use a futurize.

acdl-jenkins commented 5 years ago

Can one of the admins verify this patch?

acdl-jenkins commented 5 years ago

Can one of the admins verify this patch?

bqpd commented 5 years ago

whitelist

On Wed, Sep 11, 2019, 17:08 acdl-jenkins notifications@github.com wrote:

Can one of the admins verify this patch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/convexengineering/gpfit/pull/85?email_source=notifications&email_token=AALKAGCXMWGJSQKPUGQQNPDQJF24NA5CNFSM4IVZZ5A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QE6DY#issuecomment-530599695, or mute the thread https://github.com/notifications/unsubscribe-auth/AALKAGBK3PWZQLCKHBHUUFDQJF24NANCNFSM4IVZZ5AQ .

bqpd commented 5 years ago

thanks Berk!

On Wed, Sep 11, 2019, 17:55 Edward Burnell nburnell@gmail.com wrote:

whitelist

On Wed, Sep 11, 2019, 17:08 acdl-jenkins notifications@github.com wrote:

Can one of the admins verify this patch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/convexengineering/gpfit/pull/85?email_source=notifications&email_token=AALKAGCXMWGJSQKPUGQQNPDQJF24NA5CNFSM4IVZZ5A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QE6DY#issuecomment-530599695, or mute the thread https://github.com/notifications/unsubscribe-auth/AALKAGBK3PWZQLCKHBHUUFDQJF24NANCNFSM4IVZZ5AQ .

1ozturkbe commented 5 years ago

test this please

1ozturkbe commented 5 years ago

I'm not sure why tests aren't triggering for this repo... I ran them locally and all changes should be good. Just need the checks to complete. @bqpd?

whoburg commented 4 years ago

test this please

1ozturkbe commented 4 years ago

@priyappillai please don't forget to commit merges so that tests can run :)

priyappillai commented 4 years ago

sorry! although, is this obsolete from #86 ?

1ozturkbe commented 4 years ago

hmmm why did this PR exist then? Let me check master compatibility and then close this.

1ozturkbe commented 4 years ago

Master is good. I'm going to check PR testing on this repo in a few mins and close this.

pgkirsch commented 3 years ago

@1ozturkbe did you mean to reopen this or can it be closed again?

1ozturkbe commented 3 years ago

I have no idea why this was reopened... feel free to close if it works for Py3, which I believe it does now! (Haven't been using this lately.)

pgkirsch commented 3 years ago

Thanks, done!