search

convexengineering / gpfit

Fit posynomials to data
http://gpfit.readthedocs.io/en/latest/
MIT License
10 stars 7 forks source link

v0.1 #99

Closed pgkirsch closed 3 years ago

pgkirsch commented 3 years ago

To close #95.

@bqpd @whoburg I think I've done everything I want for v0.1. This didn't involve a few of the key things I set out to do because I realize they would (should) be backwards-incompatible API changes, which according to Semantic Versioning should be a major release (i.e. v1.0). I know it seems a little silly to have a v1.0 on GPfit already so maybe it could just be v0.2.

I would describe this v0.1 refactor as a tidier repo with better module/function/variable naming and cleaned up code, without significantly altering how GPfit works or its interface. See the checklist on #95 for a more thorough summary of what I did and didn't do. I didn't see the point in writing Getting Started if the API is about to change (I plan to keep working on this this week), but I did do a very small amount of docs housekeeping.

Let me know if this looks good to merge and if you have an opinion on the v1.0/v0.2 thing.

bqpd commented 3 years ago

oh you have to do initsolwarnings first

pgkirsch commented 3 years ago

FYI @bqpd see changes in 23adfa6b56ef6266deda70997ba96c6926dc9f61. I'll merge this branch if it looks good to you.

bqpd commented 3 years ago

left one comment, otherwise looks good!

whoburg commented 3 years ago

Amazing work @pgkirsch and @bqpd