fix sankey diagrams - Githubissues

convexengineering / gpkit

Geometric programming for engineers

http://gpkit.readthedocs.org

MIT License

206 stars 40 forks source link

fix sankey diagrams #1515

Closed bqpd closed 4 years ago

bqpd commented 4 years ago

@danielhfourie @pgkirsch

To do:

[x] add ipysankeywidget to Jenkins
[x] deduplicate constrlinks and varlinks
[x] regenerate documentation examples
[x] include fixed-variable sensitivities as if they were equality constraints in the models they're created in
[x] document maxdepth, constraints, constraintlabels, going lower down
[x] add objective to relevant variable sensitivities
[x] interactive zoom?
[ ] include identical variables (those in tight var1 <= var2 or var1 == var2 constraints)
[x] fix the attometer bug in python 3.7+

bqpd commented 4 years ago

test models please

bqpd commented 4 years ago

test models please

bqpd commented 4 years ago

test models please

bqpd commented 4 years ago

test models please

bqpd commented 4 years ago

@pgkirsch @danielhfourie this is now merged! check https://gpkit.readthedocs.io/en/latest/visint.html for the new syntax and interactive usage, and let me know if anything's unclear :D

danhfourie commented 4 years ago

@bqpd looks lovely! documentation and syntax makes sense. However when I test your WGS\ sankeys.ipynb on my machine, the model solves, and Sankey() runs without error, but no diagram shows up - just blank output. I'm running the latest gpkit master branch, ipysankeywidget 0.3.0, python 3.7.4. Also, Anaconda on Windows. I'll poke around to see what else I can find.

bqpd commented 4 years ago

ohh you need to activate the extension: run

$ jupyter nbextension enable --py --sys-prefix widgetsnbextension
$ jupyter nbextension enable --py --sys-prefix ipysankeywidget

(probably in an Anaconda Command Prompt)

bqpd commented 4 years ago

added the notes above to the documentation!