convexengineering / gpkit

Geometric programming for engineers
http://gpkit.readthedocs.org
MIT License
206 stars 40 forks source link

deduplicate gp hmaps #1553

Closed bqpd closed 3 years ago

bqpd commented 3 years ago

Closes #1551

bqpd commented 3 years ago

test models please

galbramc commented 3 years ago

test gpkit please

galbramc commented 3 years ago

test gpkit please

galbramc commented 3 years ago

test gpkit please

galbramc commented 3 years ago

@bqpd Can you replace msg-template in the .pylintrc file with this:

msg-template={path}:{module}:{line}: [{msg_id}({symbol}), {obj}] {msg}

bqpd commented 3 years ago

@galbramc done!

galbramc commented 3 years ago

Ok, I need to upgrade renyolds to Ubuntu 20.04, and then all of this should be working again.

galbramc commented 3 years ago

test gpkit please

galbramc commented 3 years ago

You can work on fixing the pylint warnings in the mean time...

bqpd commented 3 years ago

ooh new pylint

galbramc commented 3 years ago

Maybe, the Jenkins pylint configurations had gotten lost during some jenkins updates, and we were not actually catching any of the pylint warnings. So we had false green pylint results.