search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

test gpkitmodels via Jenkins #111

Closed whoburg closed 6 years ago

whoburg commented 7 years ago

Set up testing infrastructure and get baseline set up tests passing. Will encourage testing of models in this repo.

galbramc commented 7 years ago

Let me know when there is a script that can be executed by jenkins.

mjburton11 commented 6 years ago

@galbramc @bqpd can we finish this?

galbramc commented 6 years ago

Someone needs to be put in charge of setting up the infrastructure to write and run tests. Once that is in place we can have jenkins run the tests.

mjburton11 commented 6 years ago

To start, can we have it run gas_solar_trade and jho tests?

bqpd commented 6 years ago

@galbramc, we're thinking we'll want the following functionality first:

On a push to this repo, run the gpkit models tests On a PR to this repo, we'll want to use the gpkit models with the modification that it should use that particular branch of GPkit models; I imagine this'll be a small modification to your jenkins_test.py script?

(the step after this will be adding a TESTS file to this repo like all the other research repos)

bqpd commented 6 years ago

I think https://acdl.mit.edu/csi/view/convexengineering/job/gpkit_commons_Push_Models/ implements what we need, but I'm not sure how to get it to trigger on pushes

galbramc commented 6 years ago

I don't think the acdl-jenkins user has permissions to create webhooks. It needs complete admin privileges.

bqpd commented 6 years ago

it is now an admin!

galbramc commented 6 years ago

hmm, still says it only has push/pull permissions... does it take a moment to take affect?

bqpd commented 6 years ago

shouldn't!

bqpd commented 6 years ago

ah, my mistake. try now.

galbramc commented 6 years ago

yep that seems to have worked now

galbramc commented 6 years ago

Something is funny with the script. I tried cloning gpkit and we get this error on reynolds:

git clone --depth 1 git@github.com:convexengineering/gpkit.git Cloning into 'gpkit'... Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

bqpd commented 6 years ago

Oh, it should probably use http then...will modify

bqpd commented 6 years ago

This is now done!