search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

modularize the wing model #122

Closed mjburton11 closed 6 years ago

mjburton11 commented 6 years ago

Allows easy use of wing model for adding components and use as vtail or htail

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

@bqpd tests have been in like this for a while (Waiting for status to be reported). Do you know what is going on?

mjburton11 commented 6 years ago

test models please

bqpd commented 6 years ago

I think the merge conflicts have to be fixed before you can test

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

@bqpd dah, still in this waiting state...

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

@galbramc do you know why the status is "waiting for status to be reported"? It's been that way for some time, despite attempts to trigger another test using "test models please"

galbramc commented 6 years ago

hmm, no let me check jenkins (you can also always check the progress here https://acdl.mit.edu/csi/)

galbramc commented 6 years ago

test models please

mjburton11 commented 6 years ago

I was looking there, but couldn't figure out what had happened.

galbramc commented 6 years ago

did this repo get renamed?

mjburton11 commented 6 years ago

yeah I think it was library a day or two ago and now its gplibrary

galbramc commented 6 years ago

Ok. I don't actually see a test on jenkins for this repo. Did @bqpd try to set one up?

mjburton11 commented 6 years ago

Yeah we had it testing thursday I think

galbramc commented 6 years ago

Is this repo supposed to be tested just like SPAircraft and turbofan for example?

mjburton11 commented 6 years ago

No it's supposed to set up more like gpkit, testing the "research repo" like SPaircraft and turbofan and gassolar and jho

galbramc commented 6 years ago

Oh is it the gpkit_commons_PR_Models and gpkit_commons_Push_Models tests?

mjburton11 commented 6 years ago

I believe its gpkit_commons_PR_Models

galbramc commented 6 years ago

test models please

mjburton11 commented 6 years ago

that's seemed to work!

galbramc commented 6 years ago

yeah when you rename a repo you have to update the names in jenkins

galbramc commented 6 years ago

How is this repo related to models? Do you really want to say "test models" to run tests here? would you prefer "test this"?

mjburton11 commented 6 years ago

ahh, ok thanks!

galbramc commented 6 years ago

I setup "test models" with gpkit so you could run all the tests in all the model repos when you are making changes to gpkit. Does that somehow apply to this repo as well?

mjburton11 commented 6 years ago

I don't know. @bqpd is the one who knows that

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

test models please

galbramc commented 6 years ago

your tests are chaotic. You get different results every time you run them without making changes. That does not make them particularly useful tests.

mjburton11 commented 6 years ago

It's a problem with the turbofan repo, which my changes don't depend on... not sure how to best fix that.

mjburton11 commented 6 years ago

test models please

bqpd commented 6 years ago

derp, sorry, forgot the renames break jenkins

mjburton11 commented 6 years ago

test models please