explicitly add wing interior to v-h tails

convexengineering / gplibrary

Useful subsystem models

MIT License

10 stars 11 forks source link

explicitly add wing interior to v-h tails #123

Closed mjburton11 closed 6 years ago

mjburton11 commented 6 years ago

redefine fillModel in htail and vtail models

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

@galbramc @bqpd after some investigation, I believe when this run tests it's tests it is testing the research repos by checking out the gpkitmodels branch that is specified in each TESTCONFIG file. What is should do is check out the branch of the PR. The last push I did, ran all the test successfully in the PR but then once I pushed all of the research repos started failing for that reason.

bqpd commented 6 years ago

oops yes I can see how that happened. will fix tomorrow.

mjburton11 commented 6 years ago

Great. This might allow us to stop specifying the gpkitmodels branch on TESTCONFIG and just always test on master.

mjburton11 commented 6 years ago

@bqpd ping

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

teset models please

mjburton11 commented 6 years ago

@bqpd what the heck, why is turbofan failing? and only on mac?

bqpd commented 6 years ago

:(

bqpd commented 6 years ago

looking into it

bqpd commented 6 years ago

test models please

bqpd commented 6 years ago

Now it passes. ? ? ?