search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

clean up subbed vars; add wing testing method #127

Closed mjburton11 closed 6 years ago

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

@bqpd I added a testing method for the wing in wing_test.py how do we integrate testing with Jenkins for internal gpkitmodels testing?

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

@galbramc I just pushed this branch and jenkins has put this build in the queue and it seems to be stuck there and I don't know how to get it out.

galbramc commented 6 years ago

Yeah I saw it had been stuck for 20 hours. No idea what happened. I just killed it and triggered a new build. Looks like it's running now.

mjburton11 commented 6 years ago

odd, I tried to trigger a build about 20 hours ago, but it must have just got stuck in the queue. And then when I pushed again this morning it must have thought it didn't need to start another build. Is there any issue with my permissions maybe?

mjburton11 commented 6 years ago

On my end, it doesn't look like anything is running...

mjburton11 commented 6 years ago

just tried starting another build and it stuck me in the queue again.

mjburton11 commented 6 years ago

@bqpd this also should have never passed the tests. Because I deleted the input to lam in the wing model should it should have caused jho, gas_solar_trade, and solar to all fail...

mjburton11 commented 6 years ago

See #128 for fix

mjburton11 commented 6 years ago

@bqpd I think it's still testing all the repos on whatever branch is specified in TESTCONFIG, which is master for most of them.