convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

Different versions of SimPleAC #130

Closed 1ozturkbe closed 6 years ago

1ozturkbe commented 6 years ago

I'm improving up SimPleAC in many aspects as part of my thesis as a demo of extensibility and modularity of GP models. For the thesis itself, I am hoping to submit code that has been incrementally modified (SimPleAC, SimPleAC with engine, SimPleAC with submodels, SimPleAC with performance modeling etc.). I was wondering if you had preferences as to how the code is integrated into GPlibrary (eg. two extremes: only submit final version, vs. submit versions for every incremental improvement). Let me know if you have ideas.

bqpd commented 6 years ago

I would include the named different versions in a folder! If you want to reduce code duplication, each can import the previous with from FOO import *

1ozturkbe commented 6 years ago

This will be resolved with PR #172