search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

create common materials models #141

Closed mjburton11 closed 6 years ago

mjburton11 commented 6 years ago

@bqpd not sure of the best way to go about doing this, see use case in convexengineering/solar@47040c1757d303c0060481b8f6ac90fc406d202c

mjburton11 commented 6 years ago

@bqpd One problem I'm having that you'll see the in the solar commit, is that I want the wing skin material, htail skin and vtail skin materials models to all be the same. I can do that with this approach, but the materials model that is used is like the 5th one that is created. I think because importing a model causes the materials model to be created? I'm wondering if there's a better way to do this.

bqpd commented 6 years ago

(noting here that we met and discussed in lab doing this with instances created on import of gplibrary)

mjburton11 commented 6 years ago

test models please

bqpd commented 6 years ago

naw worries!

On Tue, Dec 5, 2017 at 11:17 AM, Michael Burton notifications@github.com wrote:

@mjburton11 commented on this pull request.

In gpkitmodels/init.py https://github.com/convexengineering/gplibrary/pull/141#discussion_r154997335 :

@@ -0,0 +1,2 @@ +from gpkit import Variable +g = Variable("g", 9.81, "m/s^2", "gravitational acceleration")

I pushed directly to master. Sorry I should have asked you to review this again before merging...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/convexengineering/gplibrary/pull/141#discussion_r154997335, or mute the thread https://github.com/notifications/unsubscribe-auth/ABagGMcoYpopbOrVb4-cj1K8DXL3l_yZks5s9WyrgaJpZM4Qxvhn .