search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

update bounds #149

Closed bqpd closed 6 years ago

bqpd commented 6 years ago

preparation for https://github.com/convexengineering/gpkit/pull/1238

bqpd commented 6 years ago

test models please

bqpd commented 6 years ago

@mjburton11 please review

bqpd commented 6 years ago

Merging to pass model tests on the gpkit PR

mjburton11 commented 6 years ago

@bqpd @nillst Ned.... Constants is not creating variables in CFRPFabric in gpkitmodels.GP.materials.composite. Also, looks like this had not passed tests before merging... not cool.

bqpd commented 6 years ago

Are you on the newest version of gpkit? It wouldn't have passed tests because the new gpkit hadn't been merged yet :( chicken and egg problem

bqpd commented 6 years ago

it passes tests now though!