search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

object model of solar UAV #15

Closed bqpd closed 8 years ago

bqpd commented 8 years ago

5 as an object model

bqpd commented 8 years ago

In e9f8579 it's just indented with an extra line of class declaration. Can now be merged with wing models, etc (if C_L, C_D are taken out of their current grouping).

bqpd commented 8 years ago

In 215fd6c it's adapted to use Var instead of Variable and no kwargs in Var declarations. Also, user can use SolarUAV.substitutions.update if they want to add substitutions.

bqpd commented 8 years ago

(I'm wondering if Var should be our default name? It is nicely short...especially for use with gpkit.)

whoburg commented 8 years ago

Looks great. I don't think I'm ready to move from Variable to Var (unless we do it across GPkit, which would be well outside scope of this PR). (My justification: I see value in having one name, and only one name, for each class, across the code base.)

I added one commit that reverts that change but keeps the removal of the keyword args.

@bqpd, I'm ready to merge this if you are too.

bqpd commented 8 years ago

Yup!