search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

Actuator updates #161

Closed courtin closed 6 years ago

courtin commented 6 years ago

Updates to the actuator disk propeller and electric motor models for integration into the solar model.

courtin commented 6 years ago

@galbramc these test failures seem like mosek issues on some of the VMs

bqpd commented 6 years ago

They sure do! Weird, I thought we just fixed those last month.

mjburton11 commented 6 years ago

@courtin looking good. Mostly minor changes.

courtin commented 6 years ago

@mjburton11 should be fixed now

galbramc commented 6 years ago

sorry I'm working on upgrading the VM's and hashing out some of the hickups.

galbramc commented 6 years ago

test this please

galbramc commented 6 years ago

test models please

galbramc commented 6 years ago

test models please

galbramc commented 6 years ago

looks like jenkins is back in business, and all the tests are passing for this PR.

courtin commented 6 years ago

done

mjburton11 commented 6 years ago

test this please

mjburton11 commented 6 years ago

test models please

courtin commented 6 years ago

test models please

courtin commented 6 years ago

@galbramc still something strange going on with the tests for this PR - it looks like one if being marked as failed despite all the tests passing.

bqpd commented 6 years ago

You have to go to console output to interpret those...one timed out (at 90 minutes! what kind of processor prioritization is going on on that machine anyway :p) while the other two lost internet access for a bit.

bqpd commented 6 years ago

test models please

galbramc commented 6 years ago

I was also missing a pip install cvxopt that I just added back in. Turns out that cvxopt accidentally was installed on the system for windows

galbramc commented 6 years ago

test models please

galbramc commented 6 years ago

finally. one of the VMs was busy all day.

courtin commented 6 years ago

woo!