convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

allow for outboard loads on wing as signomial model #163

Closed mjburton11 closed 6 years ago

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

@bqpd I get this error running with this branch on JHO

"/Users/jenkins/workspace/gplibrary_PR_Models/mosek/gpkit/gpkit/small_classes.py", line 242, in __div__
    def __div__(self, other): return self * other**-1
ZeroDivisionError: 0.0 cannot be raised to a negative power
mjburton11 commented 6 years ago

test models please

mjburton11 commented 6 years ago

@bqpd solved the 0.0 issue. I was substituting in values where I shouldn't have been.

bqpd commented 6 years ago

@mjburton11 should I try to clarify the error message?

mjburton11 commented 6 years ago

That could be helpful

bqpd commented 6 years ago

Where were you dividing the Hashvector?

mjburton11 commented 6 years ago

I think so? I was diving the hmap or something like that

bqpd commented 6 years ago

Hmm. I feel like adding a more specific error might not help debugging much more than debug lines in user code would.

mjburton11 commented 6 years ago

@bqpd @courtin can one of you review this PR so I can merge?