search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

Atmosphere model #171

Closed 1ozturkbe closed 6 years ago

1ozturkbe commented 6 years ago

Wanted to merge this, since SimpleAC uses this. Also it's an interesting example of a fast signomial equality (because it is really well approximated as a monomial.)

acdl-jenkins commented 6 years ago

Can one of the admins verify this patch?

bqpd commented 6 years ago

add to whitelist

bqpd commented 6 years ago

test this please

1ozturkbe commented 6 years ago

So, there are fits for every atmospheric variable, but not all of them are relevant to every problem, and they will not be bounded for every problem either. So I was thinking that people could repurpose these as they see fit.

bqpd commented 6 years ago

Sounds great! Maybe put that in a comment or docstring?

On Thu, May 24, 2018 at 4:39 PM, Berk Ozturk notifications@github.com wrote:

So, there are fits for every atmospheric variable, but not all of them are relevant to every problem, and they will not be bounded for every problem either. So I was thinking that people could repurpose these as they see fit.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/convexengineering/gplibrary/pull/171#issuecomment-391851846, or mute the thread https://github.com/notifications/unsubscribe-auth/ABagGKybnW97CirQYWLu8KHKIGcTxuHrks5t1xpwgaJpZM4UM6zv .

1ozturkbe commented 6 years ago

I thought I made that clear in the docstring, but maybe I can make it better!

1ozturkbe commented 6 years ago

Good! Merging.