search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

python3 compatibility #176

Closed 1ozturkbe closed 4 years ago

1ozturkbe commented 4 years ago

test models please

1ozturkbe commented 4 years ago

test models please

1ozturkbe commented 4 years ago

@bqpd what do we do since model tests fail? I would like to merge this ASAP since tests run on master, and I need parts of gplibrary for robust. Lmk.

bqpd commented 4 years ago

@1ozturkbe model tests need to pass before you merge onto gplibrary...they're a lot of what actually tests gplibrary's functionality!

The error seems to have been in the converter's use of from __future__ import absolute_import. The latest commit removes it and makes the commits local where necessary.

bqpd commented 4 years ago

oops, forget to check it still worked with python 3...latest commit fixes that.

bqpd commented 4 years ago

test models please

1ozturkbe commented 4 years ago

Ready to merge after review!