search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

Breguet range #22

Closed mjburton11 closed 8 years ago

mjburton11 commented 8 years ago

Got rid of Mach number, added velocity

whoburg commented 8 years ago

Is the intent of this PR just to change Mach number to Velocity? I propose we cherry-pick the relevant commit (b65e3b470b14353700b8aacec6c61734477d5970), since RvsC.ipynb is broken on this branch. If that sounds good, just let me know, and I'll do it.

mjburton11 commented 8 years ago

Yes, I just wanted to push the change of mach to velocity. So that would be great if you could cherry pick it.

mjburton11 commented 8 years ago

Where should I put RvsC.ipynb?

whoburg commented 8 years ago

Ok, b65e3b470b14353700b8aacec6c61734477d5970 has been cherry-picked to master.

whoburg commented 8 years ago

Re: RvsC.ipynb, is this a model you expect others might use, or more of a demo? I'd say that if it is working perhaps we could throw it in an examples folder?

mjburton11 commented 8 years ago

So RvsC.ipyny was just a demo. The only thing that is not working is the interactive stuff. So we could put the actual GP part in the examples folder if you want.