Closed whoburg closed 7 years ago
What is the purpose of this repo? What needs to be tested and how are the tests executed?
It's a subrepo of gpkit -- it's the models
dir here: https://github.com/convexopt/gpkit/tree/master/gpkit. We decided to split our modeling efforts from our under-the-hood code.
We currently have no tests for the models repo but we intend to create tests.
The dependencies will be the same as gpkit; nothing additional.
Ok. Let me know when you have testing and we will setup the CI. Should this be tested separate from the regular gpkit pull request and push CI jobs? Or should we just extend those scripts to include the tests of this subrep?
good question! I think we'll need to think that over.
@bqpd, wouldn't it be straightforward to define a set of default unit tests that simply runs the test()
method of every model in the gpkit-models repo? I think this is becoming important.
For sure!
Let's get testing.py
up and running so that we can fire up Jenkins on this repo.
high priority!
ping -- running testing.py
currently results in an ImportError
for me.
Having tests working on this repo is important because we currently have other repos that depend on this one! (and I'm seeing failures)
testing.py is not used by any Jenkins unit tests at the moment.
Yeah, it still references some non-existent models. testing.py
is not a current concern and we should probably delete it; any future unittesting framework is likely to be based on the research-repo tests.