unit tests currently failing

convexengineering / gplibrary

Useful subsystem models

MIT License

10 stars 11 forks source link

unit tests currently failing #6

Closed whoburg closed 7 years ago

whoburg commented 8 years ago

[x] define what a "model test" is and looks like. @bqpd says: "I think some of what we have in gpkit are candidate templates for this..."
[x] write at least one actual unit test
[ ] ask @galbramc for help setting up CI on this repo

galbramc commented 8 years ago

What is the purpose of this repo? What needs to be tested and how are the tests executed?

whoburg commented 8 years ago

It's a subrepo of gpkit -- it's the models dir here: https://github.com/convexopt/gpkit/tree/master/gpkit. We decided to split our modeling efforts from our under-the-hood code.

We currently have no tests for the models repo but we intend to create tests.

whoburg commented 8 years ago

The dependencies will be the same as gpkit; nothing additional.

galbramc commented 8 years ago

Ok. Let me know when you have testing and we will setup the CI. Should this be tested separate from the regular gpkit pull request and push CI jobs? Or should we just extend those scripts to include the tests of this subrep?

whoburg commented 8 years ago

good question! I think we'll need to think that over.

whoburg commented 8 years ago

@bqpd, wouldn't it be straightforward to define a set of default unit tests that simply runs the test() method of every model in the gpkit-models repo? I think this is becoming important.

bqpd commented 8 years ago

For sure!

whoburg commented 7 years ago

Let's get testing.py up and running so that we can fire up Jenkins on this repo.

whoburg commented 7 years ago

high priority!

whoburg commented 7 years ago

ping -- running testing.py currently results in an ImportError for me.

Having tests working on this repo is important because we currently have other repos that depend on this one! (and I'm seeing failures)

bqpd commented 7 years ago

testing.py is not used by any Jenkins unit tests at the moment.

bqpd commented 7 years ago

Yeah, it still references some non-existent models. testing.py is not a current concern and we should probably delete it; any future unittesting framework is likely to be based on the research-repo tests.