convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

1682master #80

Closed mjburton11 closed 7 years ago

mjburton11 commented 7 years ago

@whoburg: file gas_male_rubber.py ready for review.

I still have some work to do. (creating make file/md file) But I finish the most important part which was updating the main model in gas_male_rubber to incorporate a mission class and account for cases with and without a fixed engine. The answers are nearly the same as in the CDR with slight differences due to some upgrades.

NOTE: you have to checkout 82fixes in gpkit for this to run.

mjburton11 commented 7 years ago

@whoburg ready for review/squashing

I just went through and tagged all the commits that I thought were relevant so you could squash them. A lot of the earlier commits from Feb and March I wasn't even sure what was going on so I kind of just let them be...

mjburton11 commented 7 years ago

@bqpd can I delete this branch now?

bqpd commented 7 years ago

Yup! I'll do it right now

bqpd commented 7 years ago

oops, looks like another PR depends on it?