Simple commercial flight profile

convexengineering / gplibrary

Useful subsystem models

MIT License

10 stars 11 forks source link

Simple commercial flight profile #89

Closed mayork closed 7 years ago

mayork commented 7 years ago

still a work in progress, requires a few minor touch ups

fix bug when each flight segment isn't the same size
fix bug where it is dual infeasible with climb range counting towards the total flight range
rename the atm file

mayork commented 7 years ago

@whoburg here's the simple model in a PR. I'd say its ready for an initial review, but there's still a few things to take care of.

mayork commented 7 years ago

@whoburg ready for review. I addressed what was discussed yesterday. The file is Commercial_Flight_Profile_Simple.py.

mayork commented 7 years ago

@pgkirsch I'm going to start linking susbystems from your thesis into the simple flight profile code and running some sweeps, I'll send you what I get for your paper

pgkirsch commented 7 years ago

Awesome, this is sweet!

mayork commented 7 years ago

there's a few other more advanced flight profiles..the end goal is to link your whole thesis with the advanced flight profile and engine

mayork commented 7 years ago

@whoburg this is ready for review. I plan on using this to link in with the engine code for the paper. Review commit 703af95, the last two commits are sup changes superfluous.

This will not run on master right now, I think fast subinplace introduced a bug (https://github.com/hoburg/gpkit/issues/914) but it does run on master commit ea9c127aa996dd7c1803661d1234e12f926dd646 or anything prior

whoburg commented 7 years ago

@mayork sorry I failed on reviewing this. Looks like there is a conflict currently. Is this still in need of review or are you updating the branch?

mayork commented 7 years ago

@whoburg updating to use the new performance modeling style, once the question I asked yesterday is resolved I'll branch that off and push it. I'd rather you review that code than this.

whoburg commented 7 years ago

Sounds good

whoburg commented 7 years ago

@mayork, should this be closed, or is it still in progress?

mayork commented 7 years ago

@whoburg the simple flight profile is done and works well. It's integrated into the D8 code, but if there is interest in having it merged into gpkit-models I can pull over the code that uses set up and vectorizes and post it for review. If you'd rather leave it in the D8 repo and move to gpkit-models with the rest of the D8 stuff this can be closed

whoburg commented 7 years ago

let's keep it with the rest of the D8 code