search

convexengineering / gplibrary

Useful subsystem models
MIT License
10 stars 11 forks source link

adding turbofan repository to external tests #99

Closed mayork closed 7 years ago

mayork commented 7 years ago

@bqpd should be ready to merge

bqpd commented 7 years ago

Will merge once we've 1) created the push/PR jenkins jobs for this, and 2) it's passing those.

bqpd commented 7 years ago

Jenkins is ready, now the tests are just waiting on a syntax failure!

mayork commented 7 years ago

where is the syntax error occurring? I'm a little confused because when I run runtests.sh everything passes without an issue.

bqpd commented 7 years ago

If you look at the error in https://acdl.mit.edu/csi/job/gpkit_ResearchModel_turbofan_Push/5/buildnode=macys,optimizer=cvxopt/parsed_console/, it says

Couldn't parse '/Users/jenkins/workspace/gpkit_ResearchModel_turbofan_Push/buildnode/macys/optimizer/cvxopt/Fan_LPC.py'
as Python source: 'invalid syntax' at line 9
mayork commented 7 years ago

oh weird that's an old file that shouldn't be used. do the tests try and compile every file or something?

bqpd commented 7 years ago

Yeah, so that we can say what % of python lines in the repository are run by the tests.

bqpd commented 7 years ago

If it's an old file, maybe remove it?

bqpd commented 7 years ago

Or just change the extension to .py.old or something.

mayork commented 7 years ago

ah okay. there's a lot of old files i need to remove. i'll sort through them all and let you know when i think it's done.

mayork commented 7 years ago

@bqpd i have all the turbofan code in a ready to review state and the tests pass so I would like to merge this

bqpd commented 7 years ago

Confirmed! Awesome.