convexfi / spectralGraphTopology

Structured Graph Learning via Laplacian Spectral Constraints (NeurIPS 2019)
https://CRAN.R-project.org/package=spectralGraphTopology
GNU General Public License v3.0
59 stars 17 forks source link

Doesn't work without suggested package CVXR #9

Closed Enchufa2 closed 1 year ago

Enchufa2 commented 1 year ago

Problem description

Package is declared in Suggests, but it is used on package load. As a result, it doesn't work on systems without CVXR.

Example

See the build log:

** R
** inst
** byte-compile and prepare package for lazy loading
Error in library(CVXR) : there is no package called 'CVXR'
Error: unable to load R code in package 'spectralGraphTopology'
Execution halted
ERROR: lazy loading failed for package 'spectralGraphTopology'
* removing '/builddir/build/BUILDROOT/R-CRAN-spectralGraphTopology-0.2.3-1.fc37.copr4853884.x86_64/usr/local/lib/R/library/spectralGraphTopology'
error: Bad exit status from /var/tmp/rpm-tmp.gMNrVw (%install)

Expected behavior

The package should work without CVXR, or CVXR should be promoted to Imports or Depends.

Environment:

mirca commented 1 year ago

Thanks! This has been fixed in d8af461.