search

conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

feat(fares): add fare limit #154

Closed ansoncfit closed 5 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #154 into dev will decrease coverage by 0.02%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #154      +/-   ##
============================================
- Coverage     19.49%   19.46%   -0.03%     
  Complexity       75       75              
============================================
  Files            58       58              
  Lines          2144     2147       +3     
  Branches        190      190              
============================================
  Hits            418      418              
- Misses         1707     1710       +3     
  Partials         19       19
Impacted Files Coverage Δ Complexity Δ
...l/taui/controllers/RegionalAnalysisController.java 11.11% <0%> (-0.09%) 2 <0> (ø)
...java/com/conveyal/taui/models/AnalysisRequest.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b72407...08af5ff. Read the comment docs.

abyrd commented 5 years ago

Reviewing this now after conveyal/r5#453. This appears to contain some hacks that made the new R5 useable before we did a proper merge. We are probably ready to merge this soon though - we should discuss how and when to get this into a backend release.

ansoncfit commented 5 years ago

Closing in favor of #185, which cherry picks the relevant commits and avoids the hacks needed for a build before the R5 changes were merged.