Codecov Report

Merging #157 into dev will decrease coverage by 0.06%. The diff coverage is 10%.

@@             Coverage Diff              @@
##                dev     #157      +/-   ##
============================================
- Coverage     19.49%   19.43%   -0.07%     
  Complexity       75       75              
============================================
  Files            58       58              
  Lines          2144     2146       +2     
  Branches        190      190              
============================================
- Hits            418      417       -1     
- Misses         1707     1710       +3     
  Partials         19       19

Impacted Files	Coverage Δ	Complexity Δ
...java/com/conveyal/taui/models/AnalysisRequest.java	`0% <ø> (ø)`	`0 <0> (ø)`	:arrow_down:
...om/conveyal/taui/controllers/WorkerController.java	`22.44% <0%> (-0.47%)`	`6 <0> (ø)`
...l/taui/controllers/RegionalAnalysisController.java	`10.4% <20%> (-0.8%)`	`2 <0> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b72407...a618394. Read the comment docs.

ansoncfit commented 6 years ago

Actually, the renamed AnalysisRequest field shouldn't affect other users. The breaking change (for CoAXs) was in https://github.com/conveyal/analysis-backend/pull/152. I'll open a patch on this branch.

ansoncfit commented 6 years ago

Approved, assuming https://github.com/conveyal/analysis-backend/pull/158 is acceptable. Sorry for the confusion.

conveyal / analysis-backend

Set OD with _id instead of key when creating a regional analysis #157

Codecov Report