conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

Consolidate S3/offline file storage #162

Closed trevorgerhardt closed 5 years ago

trevorgerhardt commented 6 years ago

Initial implementation of consolidating our S3/file storage usage. Please give feedback on naming and implementation. I wanted to do a first pass that changed the least amount of code possible that could be updated later. Ideally we'd have an implementation we could initialize and pass between our of our libraries so that it's used the same way.

A few notes:

trevorgerhardt commented 6 years ago

@ansoncfit definitely went light on the comments expecting things to change drastically.

abyrd commented 6 years ago

Replying to @trevorgerhardt's response to @ansoncfit's review:

abyrd commented 6 years ago

One more observation: When switching to a single top-level bucket, we could use a CATEGORY enum to force everything to be in standard locations (rather than open-ended sub-bucket strings).

abyrd commented 6 years ago

I'm thinking we can't resolve all the issues here in a single pull request. We should probably copy any relevant observations in the comments and PR reviews over to #85 to track long term progress on this issue.

abyrd commented 6 years ago

Was just noticing that R5 also uses S3 storage (fetching scenarios and networks) and would ideally share components to handle this. We may want to (eventually) move these components into R5 since analysis-backend imports R5 as a dependency.