search

conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

Fix NPE that was thrown when the feed ids array was null. #179

Closed trevorgerhardt closed 5 years ago

trevorgerhardt commented 5 years ago

This just returns an empty Set<String> instead. Which should enable the request to make it to R5 and return with an appropriate error/warning. Right now users are getting a vague error when modifications are not fully filled out.

codecov-io commented 5 years ago

Codecov Report

Merging #179 into dev will decrease coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #179      +/-   ##
============================================
- Coverage     18.89%   18.88%   -0.01%     
  Complexity       72       72              
============================================
  Files            58       58              
  Lines          2159     2160       +1     
  Branches        195      195              
============================================
  Hits            408      408              
- Misses         1732     1733       +1     
  Partials         19       19
Impacted Files Coverage Δ Complexity Δ
...in/java/com/conveyal/taui/models/Modification.java 33.33% <0%> (-6.67%) 1 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7da541d...f154b3c. Read the comment docs.