search

conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

Add tests for the region and bundle controllers #180

Closed evansiroky closed 6 years ago

evansiroky commented 6 years ago
codecov-io commented 6 years ago

Codecov Report

Merging #180 into dev will increase coverage by 6.7%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev     #180     +/-   ##
===========================================
+ Coverage     18.88%   25.59%   +6.7%     
- Complexity       72      103     +31     
===========================================
  Files            58       58             
  Lines          2160     2161      +1     
  Branches        195      195             
===========================================
+ Hits            408      553    +145     
+ Misses         1733     1574    -159     
- Partials         19       34     +15
Impacted Files Coverage Δ Complexity Δ
...om/conveyal/taui/controllers/BundleController.java 66.92% <0%> (+58.26%) 14 <0> (+12) :arrow_up:
...n/java/com/conveyal/taui/AnalysisServerConfig.java 77.55% <100%> (+0.46%) 3 <0> (ø) :arrow_down:
src/main/java/com/conveyal/taui/models/Bounds.java 16.66% <0%> (+16.66%) 1% <0%> (+1%) :arrow_up:
...n/java/com/conveyal/taui/persistence/MongoMap.java 50% <0%> (+32.5%) 14% <0%> (+8%) :arrow_up:
...om/conveyal/taui/controllers/RegionController.java 78.26% <0%> (+54.34%) 8% <0%> (+6%) :arrow_up:
src/main/java/com/conveyal/taui/models/Bundle.java 75% <0%> (+57.14%) 3% <0%> (+3%) :arrow_up:
.../main/java/com/conveyal/taui/ExecutorServices.java 66.66% <0%> (+66.66%) 1% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99a9045...88b7d72. Read the comment docs.

evansiroky commented 6 years ago

Requested changes implemented. Should be ready to merge.