abyrd commented 5 years ago

This is necessary for conveyal/r5#459 to work properly. The workers can generate responses in several formats including GeoTIFF, proprietary binary grid, or JSON. We want to preserve that information when the response is repeated by the broker back to the UI.

codecov-io commented 5 years ago

Codecov Report

Merging #183 into dev will decrease coverage by 0.46%. The diff coverage is 37.5%.

@@             Coverage Diff              @@
##                dev     #183      +/-   ##
============================================
- Coverage     25.59%   25.12%   -0.47%     
  Complexity      103      103              
============================================
  Files            58       58              
  Lines          2161     2225      +64     
  Branches        195      210      +15     
============================================
+ Hits            553      559       +6     
- Misses         1574     1630      +56     
- Partials         34       36       +2

Impacted Files	Coverage Δ	Complexity Δ
...rc/main/java/com/conveyal/taui/AnalysisServer.java	`46% <100%> (ø)`	`5 <0> (ø)`	:arrow_down:
...om/conveyal/taui/controllers/BrokerController.java	`22.68% <28.57%> (ø)`	`6 <1> (?)`
...om/conveyal/taui/controllers/BundleController.java	`47.59% <0%> (-19.34%)`	`14% <0%> (ø)`
...n/java/com/conveyal/taui/AnalysisServerConfig.java	`74.07% <0%> (-3.48%)`	`3% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a846be...5b100a7. Read the comment docs.

trevorgerhardt commented 5 years ago

If the responses are GZIPed we definitely need to add that Content-Encoding. It looks like that was just removed.

abyrd commented 5 years ago

This has been observed to work on staging, merging to dev.

conveyal / analysis-backend

Preserve content-type when proxying to workers #183

Codecov Report