search

conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

EC2 enhancements #191

Closed ansoncfit closed 5 years ago

ansoncfit commented 5 years ago
codecov-io commented 5 years ago

Codecov Report

Merging #191 into dev will decrease coverage by 0.01%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #191      +/-   ##
============================================
- Coverage     24.04%   24.03%   -0.02%     
  Complexity      103      103              
============================================
  Files            60       60              
  Lines          2304     2305       +1     
  Branches        211      211              
============================================
  Hits            554      554              
- Misses         1716     1717       +1     
  Partials         34       34
Impacted Files Coverage Δ Complexity Δ
...java/com/conveyal/taui/analysis/broker/Broker.java 12.5% <0%> (-0.08%) 4 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8fbb692...e56a288. Read the comment docs.

ansoncfit commented 5 years ago

Just confirmed this works for on-demand and spot instances on staging: workers tag themselves during startup, which takes a few minutes.

We could add back the tagging during request creation (here) so that on-demand instances are tagged right away.

abyrd commented 5 years ago

It is convenient to see those tags immediately when machines start up. I think we should leave the tagging code in for on-demand launches, it's very cleanly integrated with the request to start the machine.