search

conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

EC2 Enhancements #201

Closed ansoncfit closed 5 years ago

ansoncfit commented 5 years ago

Questions

codecov-io commented 5 years ago

Codecov Report

Merging #201 into dev will decrease coverage by 0.61%. The diff coverage is 3.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #201      +/-   ##
============================================
- Coverage     24.35%   23.73%   -0.62%     
  Complexity      103      103              
============================================
  Files            59       61       +2     
  Lines          2275     2330      +55     
  Branches        206      211       +5     
============================================
- Hits            554      553       -1     
- Misses         1687     1745      +58     
+ Partials         34       32       -2
Impacted Files Coverage Δ Complexity Δ
...m/conveyal/taui/analysis/broker/WorkerCatalog.java 25% <0%> (-0.65%) 2 <0> (ø)
...com/conveyal/taui/analysis/broker/EC2Launcher.java 0% <0%> (ø) 0 <0> (?)
.../taui/analysis/broker/EC2RequestConfiguration.java 0% <0%> (ø) 0 <0> (?)
...in/java/com/conveyal/taui/analysis/broker/Job.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...om/conveyal/taui/controllers/BrokerController.java 21.78% <0%> (ø) 6 <0> (ø) :arrow_down:
...java/com/conveyal/taui/analysis/broker/Broker.java 15.32% <14.28%> (+2.82%) 4 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2366db0...aa561f6. Read the comment docs.

ansoncfit commented 5 years ago

@abyrd This should be ready for review. Our decisions on the questions above have been incorporated, and testing on staging has gone well.

Also, I wonder if using the synchronizedMap will resolve https://github.com/conveyal/analysis-backend/issues/172

ansoncfit commented 5 years ago

To answer the last question: yes, these changes now include having the broker automatically start spot instances after receiving a few regional tasks. Note TARGET_TASKS_PER_WORKER and AUTO_START_SPOT_INSTANCES_AT_TASK.