search

conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

Add Google Analytics script tag to allow proper tracking of stats #210

Closed trevorgerhardt closed 5 years ago

trevorgerhardt commented 5 years ago

Google Analytics can track page load speed for us. Since Analysis is undergoing many changes (React upgrade, database migration) it would be nice to have a historical comparison. Currently we are initializing it AFTER all of the JavaScript is downloaded, parsed, and the index file is run. This prevents us from properly tracking initial stats like page load time, time to first paint, etc. since it comes so far down the chain.

A google-analytics-tracking-id needs to be added to the staging and production properties files to enable this.

This PR is in conjunction with https://github.com/conveyal/analysis-ui/pull/861 and closes https://github.com/conveyal/analysis-ui/issues/860

codecov-io commented 5 years ago

Codecov Report

Merging #210 into dev will increase coverage by 0.05%. The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #210      +/-   ##
============================================
+ Coverage     23.26%   23.31%   +0.05%     
  Complexity      103      103              
============================================
  Files            61       61              
  Lines          2377     2380       +3     
  Branches        215      216       +1     
============================================
+ Hits            553      555       +2     
  Misses         1792     1792              
- Partials         32       33       +1
Impacted Files Coverage Δ Complexity Δ
...n/java/com/conveyal/taui/AnalysisServerConfig.java 78% <100%> (+0.44%) 3 <0> (ø) :arrow_down:
...rc/main/java/com/conveyal/taui/AnalysisServer.java 46.07% <75%> (+0.07%) 5 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f093c5...d4ebc0b. Read the comment docs.