search

conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

Improve creation of aggregation areas #213

Closed ansoncfit closed 5 years ago

ansoncfit commented 5 years ago

Initial tasks:

We should also discuss a feature to pull grids from opportunity datasets that have already been uploaded, which, along with some front-end changes, could address https://github.com/conveyal/analysis-ui/issues/509

ansoncfit commented 5 years ago

See also https://github.com/conveyal/analysis-ui/issues/473

codecov-io commented 5 years ago

Codecov Report

Merging #213 into dev-archive will increase coverage by 0.32%. The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             dev-archive     #213      +/-   ##
=================================================
+ Coverage          22.73%   23.06%   +0.32%     
- Complexity           103      104       +1     
=================================================
  Files                 63       62       -1     
  Lines               2432     2437       +5     
  Branches             220      221       +1     
=================================================
+ Hits                 553      562       +9     
+ Misses              1844     1840       -4     
  Partials              35       35
Impacted Files Coverage Δ Complexity Δ
...al/taui/controllers/AggregationAreaController.java 10.46% <0%> (-1.87%) 2 <0> (ø)
...java/com/conveyal/taui/analysis/broker/Broker.java 15.07% <0%> (ø) 4% <0%> (ø) :arrow_down:
.../conveyal/taui/analysis/broker/RedeliveryTest.java 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
.../com/conveyal/taui/persistence/OSMPersistence.java 0% <0%> (ø) 1% <0%> (ø) :arrow_down:
.../taui/analysis/broker/EC2RequestConfiguration.java 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
...l/taui/controllers/RegionalAnalysisController.java 9.21% <0%> (ø) 2% <0%> (ø) :arrow_down:
...in/java/com/conveyal/taui/analysis/broker/Job.java 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
...com/conveyal/taui/analysis/broker/EC2Launcher.java 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
.../com/conveyal/taui/analysis/broker/WorkerTags.java
...om/conveyal/taui/controllers/BrokerController.java 19.64% <0%> (+0.34%) 6% <0%> (ø) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66ca4d0...a2e556b. Read the comment docs.

ansoncfit commented 5 years ago

Related front-end change: add checkbox "Use union of shapefile features" to the create aggregation area form, and append ('union', union) or similar to the uploadAggregationArea action form data.

ansoncfit commented 5 years ago

@trevorgerhardt if you have a minute in the coming week, could you add a checkbox input to "Combine to single aggregation area," which would set the union parameter in this PR (default to false)