conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

Increase target tasks and cap on workers #215

Closed ansoncfit closed 5 years ago

ansoncfit commented 5 years ago

We've seen stable auto-scaling behavior on production for a couple months now. It seems like a good time to increase this parameter, allowing large regional analyses to complete more quickly.

codecov-io commented 5 years ago

Codecov Report

Merging #215 into dev will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #215   +/-   ##
=========================================
  Coverage     23.07%   23.07%           
  Complexity      103      103           
=========================================
  Files            62       62           
  Lines          2405     2405           
  Branches        216      216           
=========================================
  Hits            555      555           
  Misses         1817     1817           
  Partials         33       33
Impacted Files Coverage Δ Complexity Δ
...java/com/conveyal/taui/analysis/broker/Broker.java 15.07% <100%> (ø) 4 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 582dcda...ff3dbb9. Read the comment docs.

abyrd commented 5 years ago

I will want to increase this limit, but only once I've fixed https://github.com/conveyal/r5/issues/503 Hoping to get that done in the next day or two.

ansoncfit commented 5 years ago

Increasing the cap on workers will allow large regional analyses to complete more quickly.

As revised, this PR also makes small analyses take a bit longer (some were completing too quickly, given the overhead of spinning up instances).