search

conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

Mongo fetch fixes #221

Closed abyrd closed 5 years ago

abyrd commented 5 years ago

This fixes two problems with fetching and updating elements from Mongo, described in #218.

codecov-io commented 5 years ago

Codecov Report

Merging #221 into dev will decrease coverage by 0.01%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #221      +/-   ##
============================================
- Coverage     23.07%   23.05%   -0.02%     
  Complexity      103      103              
============================================
  Files            62       62              
  Lines          2405     2407       +2     
  Branches        216      218       +2     
============================================
  Hits            555      555              
- Misses         1817     1819       +2     
  Partials         33       33
Impacted Files Coverage Δ Complexity Δ
...l/taui/controllers/RegionalAnalysisController.java 9.21% <ø> (+0.06%) 2 <0> (ø) :arrow_down:
...om/conveyal/taui/controllers/BrokerController.java 19.64% <0%> (-0.55%) 6 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 582dcda...abcb1b9. Read the comment docs.

trevorgerhardt commented 5 years ago

LGTM but I think this issue needs to be addressed further. See https://github.com/conveyal/analysis-backend/issues/218#issuecomment-490341999

abyrd commented 5 years ago

LGTM but I think this issue needs to be addressed further. See #218 (comment)

This is really just a bugfix to make staging more useable in the mean time. Maybe we can bundle a few more related fixes into this PR (per your comment on #218).