conveyal / analysis-backend

Server component of Conveyal Analysis
http://conveyal.com/analysis
MIT License
23 stars 12 forks source link

Don't retry analyses that take too long #222

Closed ansoncfit closed 4 years ago

ansoncfit commented 5 years ago

The BrokerController has a catch block to handle SocketTimeoutException: when a worker takes too long to return results for a single-point request (see https://github.com/conveyal/analysis-ui/issues/412)

If the Broker returns a 202 while a worker is churning through a complex analysis, the front-end will make another request, so requests pile up on the worker. Instead of returning a 202, we could return an error:

Timeout waiting for response. For the complexity of this scenario, you may have requested too long a window between start time and end time, or too many simulated schedules. If you are using a Routing Engine version less than 4.5.1, your scenario may still be in preparation, so try again in a few minutes.

ansoncfit commented 4 years ago

Resolved in #238.