conveyal / analyst-server

DEPRECATED; see https://github.com/conveyal/analysis-ui
MIT License
37 stars 6 forks source link

Call makeValid on Shapefile creation #201

Closed mattwigway closed 9 years ago

mattwigway commented 9 years ago

Bad shapefile features aren't that uncommon. We should call GeoTools makeValid on upload.

Consider the case of a feature like this:

centroid

What is the centroid of that? It's probably somewhere on the right, but since the direction of the rings is more or less undefined, who's to say that the space on the right isn't negative space? Maybe the centroid is to the left.