conveyal / browsochrones

Create isochrones and accessibility images in the browser
MIT License
6 stars 2 forks source link

Vertical bias/glitches in isochrones #25

Closed abyrd closed 8 years ago

abyrd commented 8 years ago

This could accurately reflect the output data, but it looks so systematic across the whole region that I suspect it's a glitch in the marching squares algorithm. There are elongated vertical notches in the vector isochrones following along the vertical edges of the grid cells.

screen shot 2016-02-03 at 17 05 35

abyrd commented 8 years ago

Here's another image that might give a clue about the nature of the problem. We've got a nice smooth edge here on the isochrone because this area is over water:

image

Judging by this and the other image above, we've got notches exactly one pixel high occurring right on the pixel boundaries.

It's also worth noting that all those pixels out over the water should be considered inaccessible, but that's dealt with elsewhere in an R5 ticket.

mattwigway commented 8 years ago

This is definitely a jsolines bug, creating a ticket there: conveyal/jsolines#2

abyrd commented 8 years ago

Ah I didn't realize that jsolines was a separate project from browsochrones. Thanks.