search

conveyal / browsochrones

Create isochrones and accessibility images in the browser
MIT License
6 stars 2 forks source link

feat(propagation): Generate spectrogram data and surfaces simultaneou… #66

Closed mattwigway closed 7 years ago

mattwigway commented 7 years ago

…sly to reduce computation time

We used to do propagation twice. This PR combines spectrogram data and surface calculation, which cuts total run time by 25% at the cost of forcing surface rebuild when destination data is changed.

I'll rebase in the morning.

trevorgerhardt commented 7 years ago

Oi, working off of old code there mate!

trevorgerhardt commented 7 years ago

Geez, I've been hanging out with too many Aussies 😝

mattwigway commented 7 years ago

@trevorgerhardt any additional comments here? Rebasing ended up really messy so I did a merge commit.

trevorgerhardt commented 7 years ago

Re-applied some commits and it looks good. Going to merge.

mattwigway commented 7 years ago

For future reference, what was wrong with how I merged?

On Dec 7, 2016 2:10 AM, "Trevor Gerhardt" notifications@github.com wrote:

Merged #66 https://github.com/conveyal/browsochrones/pull/66.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/conveyal/browsochrones/pull/66#event-884808234, or mute the thread https://github.com/notifications/unsubscribe-auth/AAimruIsCEWKzvFzBwET6OQpfv8LCWlAks5rFlv-gaJpZM4LE0nD .

trevorgerhardt commented 7 years ago

Changes were not reapplied correctly.

  1. In this PR you had deleted a file, merging from dev brought it back.
  2. My changes to the callback function of getSurfaceAndSpectrogramData were not reapplied.
  3. I had removed the or clause in setting from_name and to_name because sometimes you don't want to show any (as @abyrd requested in taui)