Transitive bug fix & API change

conveyal / browsochrones

Create isochrones and accessibility images in the browser

MIT License

6 stars 2 forks source link

Transitive bug fix & API change #85

Closed trevorgerhardt closed 7 years ago

trevorgerhardt commented 7 years ago

Lot's more going on here than anticipated.

Fixed a bug in transitive rendering
Updated dependencies
Added WebWorker logging with latest WebWorkerPromiseInterface (not across the board yet)
Simplified the example

The API change is a breaking change so this will release v1.0.0.

mattwigway commented 7 years ago

@trevorgerhardt refactors look good, but how does this fix the issue reported by MIT? I don't see anything addressing the wait + inVehile + walk summing problem, or was that not the issue?

trevorgerhardt commented 7 years ago

The main issue was the breaking of the transitive rendering. Have not gotten to the bottom of the other issue.

Xin-Zheng commented 7 years ago

@mattwigway Yes, the main issue is transitive rendering. @trevorgerhardt has solved this problem by this pull request. Thanks a lot Trevor. But wait + inVehile + walk summing problem still exists.