search

conveyal / browsochrones

Create isochrones and accessibility images in the browser
MIT License
6 stars 2 forks source link

Add flow #88

Closed trevorgerhardt closed 7 years ago

trevorgerhardt commented 7 years ago

Also, quite a bit of refactoring around the insanity of get-transitive-data 😅

codecov-io commented 7 years ago

Codecov Report

Merging #88 into add-tests will decrease coverage by 0.1%. The diff coverage is 79.47%.

Impacted file tree graph

@@              Coverage Diff              @@
##           add-tests      #88      +/-   ##
=============================================
- Coverage       63.1%   62.99%   -0.11%     
=============================================
  Files             14       16       +2     
  Lines            374      508     +134     
  Branches          74       88      +14     
=============================================
+ Hits             236      320      +84     
- Misses           138      163      +25     
- Partials           0       25      +25
Impacted Files Coverage Δ
lib/worker-handlers.js 0% <0%> (-5.13%) :arrow_down:
lib/index.js 0% <0%> (-18.89%) :arrow_down:
lib/isochrone-tile.js 0% <0%> (-14.29%) :arrow_down:
lib/stop-tree-cache.js 93.33% <100%> (ø) :arrow_up:
lib/grid.js 100% <100%> (ø) :arrow_up:
lib/generate-destination-data.js 100% <100%> (ø) :arrow_up:
lib/accessibility-for-grid.js 100% <100%> (ø) :arrow_up:
lib/propagation.js 100% <100%> (ø) :arrow_up:
lib/surface.js 84.21% <100%> (ø)
lib/constants.js 100% <100%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58aa22c...9967817. Read the comment docs.

trevorgerhardt commented 7 years ago

@evansiroky & @mattwigway changes are ready for another look 👌

trevorgerhardt commented 7 years ago

@evansiroky I left Function in instances where log is being passed around.