search

conveyal / gtfs-editor

A web-based GTFS editing framework. THIS PROJECT IS DEPRECATED. See https://github.com/ibi-group/datatools-ui for current version.
https://github.com/ibi-group/datatools-ui
MIT License
134 stars 63 forks source link

Cannot create accounts #216

Open markjd84 opened 9 years ago

markjd84 commented 9 years ago

Under "Account Management > Create Account" it is impossible to select a new username that is accepted as valid. Looking at the code in Admin.checkUsername() I suspect the responses are the wrong way round: it currently says 

 if (!exists)
    badRequest();

but I suspect it should be if(exists). For example, any random string fhghf is reported as already taken.

JWJoubert commented 9 years ago

I don't think I have commit rights, and have not seen any updates on this issue. I have the same problem, and it is becoming quite urgent/critical for me. Is there a chance, Mark, that you can make the change and commit please? Or is there a specific workflow. If so, and you let me know, I'll try and get the ball rolling on my side and get this done.

Thanks! Johan

JWJoubert commented 9 years ago

I've been able to fix this locally, and it seems to work. With permission I can commit the (really minor) change - I just don't know if there might be, given the overall design, unintended consequences.

markjd84 commented 9 years ago

Sorry, I don't have commit rights either - I've been using a local change! Cheers.