conveyal / gtfs-lib

A library for loading and saving GTFS feeds of arbitrary size with disk-backed storage
BSD 2-Clause "Simplified" License
71 stars 38 forks source link

Remove unneeded arguments from ConditionalRequirements classes #320

Closed evansiroky closed 3 years ago

evansiroky commented 3 years ago

Checklist

Description

This PR refactors the ConditionRequirement class further by moving subclass-specific fields to those subclasses. It also fixes what seems to be an error in the logic within the FieldNotEmptyAndMatchesValueCheck check method.

br648 commented 3 years ago

Thanks. On review I don't think the dependentFieldCheck is needed now that we have specific classes for each conditional check.