conveyal / gtfs-lib

A library for loading and saving GTFS feeds of arbitrary size with disk-backed storage
BSD 2-Clause "Simplified" License
71 stars 38 forks source link

Flex close polygon #358

Closed br648 closed 2 years ago

br648 commented 2 years ago

Checklist

Description

Update to validate polygons and to add an additional shape (matching the first shape) if the polygon has not already been closed.

br648 commented 2 years ago

@binh-dam-ibigroup and @miles-grant-ibigroup I'm not sure what has happened with the amount of tests in JDBCTableWriterTest. I may have branched from flex-table-additons instead of dev-flex. Having said that the only diff between dev-flex and flex-table-additions is the pattern reconciliation tests, so I've merged this into dev-flex (and then merged dev-flex into flex-close-polygon). The additional tests in JDBCTableWriterTest remain when I would only expect canValidateLocationShapes()!

@miles-grant-ibigroup I'll catch you later to discuss, but I think we can merge all working flex branches into dev-flex.

br648 commented 2 years ago

@binh-dam-ibigroup and @miles-grant-ibigroup I'm not sure what has happened with the amount of tests in JDBCTableWriterTest. I may have branched from flex-table-additons instead of dev-flex. Having said that the only diff between dev-flex and flex-table-additions is the pattern reconciliation tests, so I've merged this into dev-flex (and then merged dev-flex into flex-close-polygon). The additional tests in JDBCTableWriterTest remain when I would only expect canValidateLocationShapes()!

@miles-grant-ibigroup I'll catch you later to discuss, but I think we can merge all working flex branches into dev-flex.

JDBCTableWriterTest test are now as expected after a push.