search

conveyal / otp.js

OTP Javascript Client & Data Bindings
MIT License
19 stars 20 forks source link

route color in narrative not styled correctly #70

Closed kpwebb closed 9 years ago

kpwebb commented 9 years ago
screenshot 2015-07-31 10 13 16
abyrd commented 9 years ago

This is a functioning but incomplete feature. It clearly doesn't look fabulous. @kpwebb are you saying this got deployed to a production environment without being finished? If so then we need to revisit our release process for otp.js.

abyrd commented 9 years ago

BTW there is a corresponding pull request in OTP that should resolve foreground text contrast problems. https://github.com/opentripplanner/OpenTripPlanner/pull/2029

I think we should use the same foreground color for the links and the descriptive text though (maybe with underline on hover). We don't want to have to automatically guess another color combination.

trevorgerhardt commented 9 years ago

We spoke on Friday about this. Resolved in babf565eba66e93197182861d47c60a7b5758a89 using colored borders so that a contrasting text isn't necessary.