Closed ccyrille closed 4 years ago
Hi @landonreed, thanks for your nice review ! I agree with all the recommandations you made, and pushed the associated changes. Don't hesitate to come back to me if needed...
Sorry to bother you @landonreed but any chance you can review this PR ? Do you need me to do additional work from me ?
Hi @demory @trevorgerhardt, sorry to bother you but I am stuck here. I have put some effort making the otp.js usable / maintainable again by moving to webpack, but I haven't here from Landon since then. Could you help ?
Hi @ccyrille. We no longer maintain this project as we don't use it internally anymore. It appears the OpenTripPlanner project has mostly moved on from it also with https://github.com/opentripplanner/otp-react-redux and https://github.com/opentripplanner/otp-ui.
The next merged PR should probably be an update relating to the status of this project pointing users to more active client side OTP libs and a more up to date repo for this project.
Hi @trevorgerhardt, hoping that I didn't work for nothing :
master
so there is no overhead for you.Thanks, Cyrille
Executing a
make build
on the master, even by removing disappeared dependencies likekpwebb/select2
, I got the following :Problem appears to be at the heart of
component
package manager, which is not maintained since 2015 (see https://github.com/componentjs/component/issues/639). I decided to migrate the whole project towebpack
, sticking as much as possible to the current implementation.This also solve the following issue : https://github.com/conveyal/otp.js/issues/91