Open abyrd opened 4 years ago
com.conveyal.gtfs.GTFSFeed#getShape returns null if the Shape has a zero-length shape_dist_traveled array. So if the Shape constructor hits an exception, it could set its fields to have an empty geometry and empty shape_dist_traveled array; alternatively the getShape method could catch exceptions and return null. Either way, more Javadoc should be added to explain error conditions and return values.
Using GTFS from http://gtfs.ovapi.nl/ Marco at Movares reports:
We need to either tolerate this and log an error, or throw an exception containing a clearer description of the problem and a specific shape or trip ID.
It is noteworthy that for analysis work we don't even need the shapes, so it's kind of a shame that bad shape data can halt the import process.