search

conveyal / r5

Developed to power Conveyal's web-based interface for scenario planning and land-use/transport accessibility analysis, R5 is our routing engine for multimodal (transit/bike/walk/car) networks with a particular focus on public transit
https://conveyal.com/learn
MIT License
272 stars 71 forks source link

Use pixel centers as points in web Mercator grids #894

Closed abyrd closed 8 months ago

abyrd commented 8 months ago

Travel time and accessibility results will be slightly different when computed with workers after this change. Pre-built linkages in saved networks will not be affected - the entire network must be rebuilt to ensure they are consistent, so this requires a network version bump. However we are also updating to Kryo 5 serialization format, so if both changes are introduced at once in a release we need only bump the network version number once.

abyrd commented 8 months ago

Simpson desert tests are failing, which is not surprising as travel times are slightly different with this linking strategy. PR #896 changes those tests so they no longer depend on the position of the destination grid. That PR will need to be merged before this one's tests will pass.

abyrd commented 8 months ago

Tests are now passing with the Simpson Desert test changes merged in. I think this is ready for final review.

abyrd commented 8 months ago

@trevorgerhardt merge commit to combine the use of extents with pixelToCenterX invalidated your review.