conveyal / r5

Developed to power Conveyal's web-based interface for scenario planning and land-use/transport accessibility analysis, R5 is our routing engine for multimodal (transit/bike/walk/car) networks with a particular focus on public transit
https://conveyal.com/learn
MIT License
272 stars 71 forks source link

Final and static field modifiers in Broker #922

Closed abyrd closed 5 months ago

abyrd commented 6 months ago

Many constants (as indicated by capitalization) were not static. One field always set in the constructor was not final. The list of resultAssemblers WAS static. This may be a remnant of pre-component design. This was not problematic because we never construct more than one Broker, but by design it should be possible to do so.

These changes are not expected to improve or alter behavior, so if we may do a bugfix point release (e.g. for #919 through #921) we may want to defer merging this until the next full round of testing for a release.