search

convict-git / KoraKaagaz

A collaborative whiteboard application as part of CS5617 Software Engineering project at IIT Palakkad
MIT License
13 stars 31 forks source link

Resource leak #148

Closed sravand123 closed 3 years ago

sravand123 commented 3 years ago

Closes #131

convict-git commented 3 years ago

@Prudhvis-gitrepo @sravand123 What about the socket in ServerManager.java?

sravand123 commented 3 years ago

@Prudhvis-gitrepo @sravand123 What about the socket in ServerManager.java?

@convict-git I found no way to close socket in serverManager .. as it in infinite loop.. if we try to close socket after while loop it is throwing code unreachable error

Prudhvis-gitrepo commented 3 years ago

@Prudhvis-gitrepo @sravand123 What about the socket in ServerManager.java I'm not the author of ServerManager.java mentioning me is inappropriate.

convict-git commented 3 years ago

@sravand123 Please open a new issue for the socket in ServerManager.java. You may not fix it now but it will be good for future reference.

Merging.